Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SQL statements, add claryfing comments in the Teradata quickstart #6364

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix SQL statements, add claryfing comments in the Teradata quickstart #6364

merged 1 commit into from
Nov 5, 2024

Conversation

adamtwo
Copy link
Contributor

@adamtwo adamtwo commented Oct 25, 2024

What are you changing in this pull request and why?

Fix SQL statements, add claryfing comments in the Teradata quickstart

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

@adamtwo adamtwo requested a review from a team as a code owner October 25, 2024 18:02
@vercel Vercel
Copy link

vercel bot commented Oct 25, 2024

Someone is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: medium This change will take up to a week to address labels Oct 25, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 28, 2024 9:51am

@adamtwo
Copy link
Contributor Author

adamtwo commented Oct 30, 2024

Hey, the preview looks good. What do I need to get this PR merged?

mirnawong1
mirnawong1 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @adamtwo , thanks for opening this up and updating it! looks good to me and will get this merged for you

@mirnawong1 mirnawong1 merged commit 96e1702 into dbt-labs:current Nov 5, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content guides Knowledge best suited for Guides size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamtwo @mirnawong1